zenghuapei
/
cyywl_server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mall：code review 商品的添加和修改 VO；微调商品的 SPU/SKU 表

pull/2/head
YunaiV 2022-08-23 00:38:49 +08:00
parent a11dd1be28
commit 81666e3b62
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/sku/ProductSkuServiceImpl.java
View File

@ -2,12 +2,10 @@ package cn.iocoder.yudao.module.product.service.sku;
import cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil; import cn.iocoder.yudao.framework.common.exception.util.ServiceExceptionUtil;
import cn.iocoder.yudao.framework.common.pojo.PageResult; import cn.iocoder.yudao.framework.common.pojo.PageResult;
import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyCreateReqVO;
import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyRespVO; import cn.iocoder.yudao.module.product.controller.admin.property.vo.ProductPropertyRespVO;
import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueCreateReqVO;
import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueRespVO; import cn.iocoder.yudao.module.product.controller.admin.propertyvalue.vo.ProductPropertyValueRespVO;
import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuBaseVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuBaseVO;
import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateReqVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuCreateOrUpdateReqVO;
import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuPageReqVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuPageReqVO;
import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuUpdateReqVO; import cn.iocoder.yudao.module.product.controller.admin.sku.vo.ProductSkuUpdateReqVO;
import cn.iocoder.yudao.module.product.convert.sku.ProductSkuConvert; import cn.iocoder.yudao.module.product.convert.sku.ProductSkuConvert;
@ -90,7 +88,7 @@ public class ProductSkuServiceImpl implements ProductSkuService {
} }
@Override @Override
public void validateSkus(List<ProductSkuCreateReqVO> list) { public void validateSkus(List<ProductSkuCreateOrUpdateReqVO> list) {
List<ProductSkuBaseVO.Property> skuPropertyList = list.stream().flatMap(p -> Optional.of(p.getProperties()).orElse(new ArrayList<>()).stream()).collect(Collectors.toList()); List<ProductSkuBaseVO.Property> skuPropertyList = list.stream().flatMap(p -> Optional.of(p.getProperties()).orElse(new ArrayList<>()).stream()).collect(Collectors.toList());
// 校验规格属性以及规格值是否存在 // 校验规格属性以及规格值是否存在
List<Long> propertyIds = skuPropertyList.stream().map(ProductSkuBaseVO.Property::getPropertyId).collect(Collectors.toList()); List<Long> propertyIds = skuPropertyList.stream().map(ProductSkuBaseVO.Property::getPropertyId).collect(Collectors.toList());

4
yudao-module-mall/yudao-module-product-biz/src/main/java/cn/iocoder/yudao/module/product/service/spu/ProductSpuServiceImpl.java
View File

@ -56,7 +56,7 @@ public class ProductSpuServiceImpl implements ProductSpuService {
// 校验分类 // 校验分类
categoryService.validateProductCategory(createReqVO.getCategoryId()); categoryService.validateProductCategory(createReqVO.getCategoryId());
// 校验SKU // 校验SKU
List<ProductSkuCreateReqVO> skuCreateReqList = createReqVO.getSkus(); List<ProductSkuCreateOrUpdateReqVO> skuCreateReqList = createReqVO.getSkus();
if(createReqVO.getSpecType() == 1) { if(createReqVO.getSpecType() == 1) {
productSkuService.validateSkus(skuCreateReqList); productSkuService.validateSkus(skuCreateReqList);
} }
@ -78,7 +78,7 @@ public class ProductSpuServiceImpl implements ProductSpuService {
// 校验分类 // 校验分类
categoryService.validateProductCategory(updateReqVO.getCategoryId()); categoryService.validateProductCategory(updateReqVO.getCategoryId());
// 校验SKU // 校验SKU
List<ProductSkuCreateReqVO> skuCreateReqList = updateReqVO.getSkus(); List<ProductSkuCreateOrUpdateReqVO> skuCreateReqList = updateReqVO.getSkus();
if(updateReqVO.getSpecType() == 1) { if(updateReqVO.getSpecType() == 1) {
productSkuService.validateSkus(skuCreateReqList); productSkuService.validateSkus(skuCreateReqList);
} }